Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to unfocus comment field without the mouse #20752

Closed
technomancy opened this issue Aug 10, 2022 · 8 comments
Closed

No way to unfocus comment field without the mouse #20752

technomancy opened this issue Aug 10, 2022 · 8 comments
Labels
topic/ui-interaction Change the process how users use Gitea instead of the visual appearance type/bug

Comments

@technomancy
Copy link

Description

After typing a comment, normally you want to submit it. However, pressing tab (which should move the browser focus on to the next page element) just inserts a literal tab character, which is not useful in the context of the comment entry box. Pressing escape (which is supposed to unfocus the textarea) has no effect. Thus it is necessary to use the mouse to submit a comment, which is an unfortunate accessibility bug.

Repro URL: https://try.gitea.io/technomancy/pengbot/issues/new

I have reproduced in both Firefox and Chromium.

Gitea Version

1.17.0+52-g7b04535

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

I first noticed this on codeberg.org but made sure it was also reproducible on try.gitea.io.

Database

No response

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Aug 10, 2022

@technomancy
Copy link
Author

Thanks for the workaround. That will be useful to me while I wait for this to be fixed and deployed. =)

However, this is still an important bug to fix, because you don't always want to submit the issue; sometimes you want to interact with some other elements on the page first.

@wxiaoguang wxiaoguang added the topic/ui-interaction Change the process how users use Gitea instead of the visual appearance label Aug 11, 2022
@wxiaoguang
Copy link
Contributor

I agree that the a11y should be improved. At the moment Gitea doesn't have good a11y support (search the issues with "accessibility"), some UI elements just do not work with keyboard. So, improving Gitea's a11y is a big topic.

@silverwind
Copy link
Member

This is codemirror behaviour. It being a code editor, tab inserts literal tab, so it doesn't act like a regular textarea would be expected. Workaround it to use the textarea button for now, we should make this experience better eventually.

@KiaraGrouwstra
Copy link
Contributor

actually, as per the demos for 5 and 6 this behavior appears amended in 6.
perhaps we could just upgrade it?
i don't actually see where we've defined this dependency tho...

@KiaraGrouwstra
Copy link
Contributor

looks like i got thrown off by codemirror being an implicit dependency thru EasyMDE now.
that means this now seems to depend on Ionaru/easy-markdown-editor#505.

@KiaraGrouwstra
Copy link
Contributor

potentially addressed by #10729

@silverwind
Copy link
Member

Fixed with #23876, tab now works.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui-interaction Change the process how users use Gitea instead of the visual appearance type/bug
Projects
None yet
Development

No branches or pull requests

4 participants