Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fomantic progress module #19760

Merged
merged 3 commits into from
May 20, 2022
Merged

Remove fomantic progress module #19760

merged 3 commits into from
May 20, 2022

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented May 19, 2022

Replace it with HTML <progress> element. The bar won't animate or go green at 100% anymore but I think it's not something that fits stylistically anyways.

Screen Shot 2022-05-19 at 20 20 04

Screen Shot 2022-05-19 at 20 19 48

Screen Shot 2022-05-19 at 20 19 28

Screen Shot 2022-05-19 at 20 19 12

Screen Shot 2022-05-19 at 20 19 03

Replace it with HTML `<progress>` element. The bar won't go green at
100% anymore but I think it's not something that fits stylistically
anyways.
@silverwind silverwind added the topic/ui Change the appearance of the Gitea UI label May 19, 2022
@silverwind silverwind added this to the 1.17.0 milestone May 19, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 20, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 20, 2022
@wxiaoguang
Copy link
Contributor

Will this make the progress green?

progress[max=100][value=100] {
    color etc
}

@wxiaoguang
Copy link
Contributor

wxiaoguang commented May 20, 2022

It seems working. https://jsfiddle.net/k8rjmaqu/ (it's just a personal opinion to make 100% as green, in case some people like it, I am fine to either. not a blocker)

image

@6543 6543 merged commit ac8bee6 into go-gitea:main May 20, 2022
@silverwind
Copy link
Member Author

Will this make the progress green?

progress[max=100][value=100] {
    color etc
}

Yes it would work for the case where max is 100 like it is for the milestone bar, but I think we could also opt to make the milestone bar always green, like GitHub does.

@silverwind silverwind deleted the progress branch May 20, 2022 08:21
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 20, 2022
* giteaofficial/main:
  Move org functions (go-gitea#19753)
  [doctor] pq: syntax error at or near "." quote user table name (go-gitea#19765)
  [doctor] update the help with fix capabilities (go-gitea#19762)
  Remove fomantic progress module (go-gitea#19760)
  Make Ctrl+Enter (quick submit) work for issue comment and wiki editor (go-gitea#19729)
  Enable packages by default again (as described by docs) (go-gitea#19746)
  Replace blue button and label classes with primary (go-gitea#19763)
  Fix org package owner permissions (go-gitea#19742)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
Replace it with HTML `<progress>` element. The bar won't go green at
100% anymore but I think it's not something that fits stylistically anyways.
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants