New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] ensure that the `closed_at` is set for closed #5450

Merged
merged 2 commits into from Dec 2, 2018

Conversation

4 participants
@romankl
Contributor

romankl commented Dec 2, 2018

backport for: #5449

right now the closed_at field for json responses is not filled during the APIIssue creation for api responses.

For a closed issue you get a result like:

"state":"open","comments":0,"created_at":"2018-11-29T16:39:24+01:00",
"updated_at":"2018-11-30T10:49:19+01:00","closed_at":null,
"due_date":null,"pull_request":null}

which has no information about the closing date. (which exists in the
db and ui)
with this PR the result changes to this:

:null,"assignee":null,"assignees":null,
"state":"closed",
"comments":0,"created_at":"2018-11-29T16:43:05+01:00",
"updated_at":"2018-12-02T19:17:05+01:00",
"closed_at":"2018-12-02T19:17:05+01:00",
"due_date":null,"pull_request":null}

fixes: #5446

ensure that the `closed_at` is set for closed
right now the `closed_at` field for json responses is not filled during
the `APIIssue` creation for api responses.

For a closed issue you get a result like:
```json
"state":"open","comments":0,"created_at":"2018-11-29T16:39:24+01:00",
"updated_at":"2018-11-30T10:49:19+01:00","closed_at":null,
"due_date":null,"pull_request":null}
```
which has no information about the closing date. (which exists in the
db and ui)
with this PR the result changes to this:

```json
:null,"assignee":null,"assignees":null,
"state":"closed",
"comments":0,"created_at":"2018-11-29T16:43:05+01:00",
"updated_at":"2018-12-02T19:17:05+01:00",
"closed_at":"2018-12-02T19:17:05+01:00",
"due_date":null,"pull_request":null}
```

fixes: #5446
Signed-off-by: Roman <romaaan.git@gmail.com>

@romankl romankl force-pushed the romankl:r-backport-json-closed-at branch from 43ea7e0 to 8fc4d00 Dec 2, 2018

@adelowo

adelowo approved these changes Dec 2, 2018

@bkcsoft bkcsoft added the lgtm/need 1 label Dec 2, 2018

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Dec 2, 2018

@techknowlogick techknowlogick added this to the 1.6.1 milestone Dec 2, 2018

@techknowlogick techknowlogick merged commit 8e4a0a9 into go-gitea:release/v1.6 Dec 2, 2018

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details
@techknowlogick

This comment has been minimized.

Member

techknowlogick commented Dec 2, 2018

@romankl thanks 😄

@romankl romankl deleted the romankl:r-backport-json-closed-at branch Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment