Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] ensure that the closed_at is set for closed #5450

Merged

Commits on Dec 2, 2018

  1. ensure that the closed_at is set for closed

    right now the `closed_at` field for json responses is not filled during
    the `APIIssue` creation for api responses.
    
    For a closed issue you get a result like:
    ```json
    "state":"open","comments":0,"created_at":"2018-11-29T16:39:24+01:00",
    "updated_at":"2018-11-30T10:49:19+01:00","closed_at":null,
    "due_date":null,"pull_request":null}
    ```
    which has no information about the closing date. (which exists in the
    db and ui)
    with this PR the result changes to this:
    
    ```json
    :null,"assignee":null,"assignees":null,
    "state":"closed",
    "comments":0,"created_at":"2018-11-29T16:43:05+01:00",
    "updated_at":"2018-12-02T19:17:05+01:00",
    "closed_at":"2018-12-02T19:17:05+01:00",
    "due_date":null,"pull_request":null}
    ```
    
    fixes: go-gitea#5446
    Signed-off-by: Roman <romaaan.git@gmail.com>
    romankl authored and r-52 committed Dec 2, 2018
    Configuration menu
    Copy the full SHA
    8fc4d00 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3cbd02e View commit details
    Browse the repository at this point in the history