Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchRepositoryByName improvements and unification #6897

Merged

Conversation

@zeripath
Copy link
Contributor

commented May 9, 2019

This PR improves SearchRepositoryByName to return repositories that are accessible to the current user and returns public repositories that a user is a member of a team of.

Fixes #5454
Fixes #6670
Fixes #6195

Likely some others too

zeripath added some commits May 9, 2019

@zeripath

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

Fixes #6670

@GiteaBot GiteaBot added the lgtm/need 2 label May 9, 2019

@codecov-io

This comment has been minimized.

Copy link

commented May 9, 2019

Codecov Report

Merging #6897 into master will increase coverage by 0.06%.
The diff coverage is 92.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6897      +/-   ##
==========================================
+ Coverage   41.41%   41.47%   +0.06%     
==========================================
  Files         441      441              
  Lines       59724    59663      -61     
==========================================
+ Hits        24732    24745      +13     
+ Misses      31755    31695      -60     
+ Partials     3237     3223      -14
Impacted Files Coverage Δ
models/repo_list.go 72.08% <100%> (+5.23%) ⬆️
routers/api/v1/repo/repo.go 57.03% <100%> (+1.43%) ⬆️
routers/user/home.go 53.28% <78.57%> (+3.39%) ⬆️
routers/user/profile.go 50.48% <81.25%> (+12.39%) ⬆️
modules/log/event.go 64.46% <0%> (-1.53%) ⬇️
models/org.go 69.77% <0%> (-0.96%) ⬇️
models/repo.go 47.27% <0%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fb1ad7...9ac2f63. Read the comment docs.

integrations/sqlite.ini Outdated Show resolved Hide resolved

@lunny lunny added this to the 1.9.0 milestone May 10, 2019

routers/user/profile.go Outdated Show resolved Hide resolved
routers/user/profile.go Outdated Show resolved Hide resolved

zeripath added some commits May 10, 2019

@zeripath zeripath referenced this pull request May 13, 2019
2 of 7 tasks complete

@zeripath zeripath requested review from lafriks and sapk May 13, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels May 13, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels May 15, 2019

@mrsdizzie

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

👍 tested for a while and fixes all of those linked issues thanks much!

@techknowlogick techknowlogick merged commit 56ae539 into go-gitea:master May 15, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

lafriks added a commit to lafriks-fork/gitea that referenced this pull request May 20, 2019

@lafriks lafriks referenced this pull request May 20, 2019
2 of 7 tasks complete

@zeripath zeripath deleted the zeripath:fix-#5454-improve-api-repos-search branch May 20, 2019

@lassebm

This comment has been minimized.

Copy link

commented May 20, 2019

@techknowlogick Please consider backporting to 1.8. Thanks.

zeripath added a commit to zeripath/gitea that referenced this pull request May 20, 2019

lafriks added a commit that referenced this pull request May 21, 2019

SearchRepositoryByName improvements and unification (#6897) (#7002)
* SearchRepositoryByName improvements and unification (#6897)

* Update tests

Co-Authored-By: zeripath <art27@cantab.net>

* Update tests

Co-Authored-By: zeripath <art27@cantab.net>

* Update tests

Co-Authored-By: zeripath <art27@cantab.net>

* Fix tests

jeffliu27 added a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.