Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split gl.go into separate pieces #79

Merged
merged 5 commits into from
Oct 24, 2012

Conversation

pwaller
Copy link
Contributor

@pwaller pwaller commented Oct 20, 2012

No description provided.

@ghost ghost assigned pwaller Oct 20, 2012
@ghost ghost mentioned this pull request Oct 20, 2012
@pwaller
Copy link
Contributor Author

pwaller commented Oct 20, 2012

So I've made a first attempt above. The idea is a little fraught because apart from the objects and a few other things, it's not totally clear how best to split things, so you're still left with a giant gl.go file. Secondly, every file using the C api needs the cgo directives, which is unfortunate, especially since they might need updating for windows/mac.

@ghost
Copy link

ghost commented Oct 20, 2012

The repeating CGO directives can probably be moved to a separate gl.h file. You then only have to include that one. The #cgo bits only have to be listed once.

@pwaller
Copy link
Contributor Author

pwaller commented Oct 20, 2012

Unfortunately, that doesn't work for the #cgo directive :-(

@ghost
Copy link

ghost commented Oct 20, 2012

Weird. It seems to be fine in the glfw package. Only glfw.go carries the #cgo bits.

@pwaller
Copy link
Contributor Author

pwaller commented Oct 20, 2012

Ah, of course.

@ghost
Copy link

ghost commented Oct 20, 2012

Looks good to me. If @banthar has no further comments, this is good to go as far as I'm concerned.

banthar added a commit that referenced this pull request Oct 24, 2012
Split gl.go into separate pieces
@banthar banthar merged commit aaee786 into go-gl-legacy:master Oct 24, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants