Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change import path according to early 2015 plan. #1

Closed
dmitshur opened this issue Feb 23, 2015 · 3 comments
Closed

Change import path according to early 2015 plan. #1

dmitshur opened this issue Feb 23, 2015 · 3 comments

Comments

@dmitshur
Copy link
Member

Move gl bindings package into their respective subfolders, as described in the document.

Once gl repo is moved out of the way into go-gl-legacy org, this repo should be renamed to gl, master branch should be created and made default, instead of current early-2015-overhaul branch, then this issue can be closed.

This repo was created using the following steps:

  1. Starting with current glow repo master branch, I rewrote history to keep only the history of GL bindings and exclude everything related to glow itself:

    git filter-branch --tree-filter 'mkdir /tmp/rewrite/ ; cp -R ./gl-compatibility ./gl-core ./gl ./procaddr ./LICENSE /tmp/rewrite ; rm -rf ./.gitignore ./* ; cp -R /tmp/rewrite/ ./ ; rm -rf /tmp/rewrite/' --prune-empty HEAD
    
  2. I then rebased on top of the initial commit. This got rid of merge commits (many of which were empty, since they were relevant to glow itself).

    git rebase --committer-date-is-author-date 0d8b6d97be83d3eb6b5d369f16e688cad9e173ed
    
  3. After the rebase, all GL bindings were moved into their respective subfolders. See commit 5389d15.

  4. Internal import paths were rewritten to use the future new repo. See commit 8aec438.

  5. A modified README.md was added (taken from glow repo, but with glow-specific parts removed). See commit 89cb87f.

Please review.

@slimsag
Copy link
Member

slimsag commented Feb 23, 2015

LGTM

@dmitshur
Copy link
Member Author

I've looked everything over, it seems to be as expected.

I've tested v2.1/gl, all-core/gl and v4.1-core/gl, they all worked (tested with go-gl/glow repo removed).

LGTM.

@dmitshur
Copy link
Member Author

This is done now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants