Regenerate with KHR header and overloads #135
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends
go-gl/gl
in the following ways:Regenerate with KHR header
As identified in go-gl/gl comment , newest API specs all require the presence of
KHR/khrplatform.h
.glow
was extended to download and provide this file as well, and this PR is the result of re-generating all APIs.Fixes #125 .
checkptr
problem fixesAs a side-effect of the re-generation, the previously introduced "overloads" feature is now also included.
To highlight the issue with
checkptr
detector,README.md
was extended to detail what to do in such error cases.Fixes #124 .
Should also handle #80 - though I don't think reported affected functions have a necessary overload.
Module
A module file was added to allow
go-gl/gl
to be used outside aGOPATH
environment.Futhermore, the code generation call to
glow
was extended to specify all paths, in order to allowglow
also to be used outsideGOPATH
. (This change is in tandem with the corresponding PR go-gl/glow#115 .)Detail: The minimum version was set to be Go 1.9. Although Travis build did specify 1.4 to be the earliest, this version could not be brought to work: The linker rejected the passed parameters (
/usr/bin/ld: -r and -pie may not be used together
). Version 1.9 was chosen because generated CGo code was not compatible with older versions when run with a 1.16 compiler (_cgo_gotypes.go:32:6: type aliases only supported as of -lang=go1.9
)Should help to get going with #102 .
Change of CI
Travis was dropped, and instead GitHub actions are in use now. This allows for a more complete test-matrix of multiple Go versions and environments.