Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate with KHR header and overloads #135

Merged
merged 8 commits into from
Apr 26, 2021
Merged

Regenerate with KHR header and overloads #135

merged 8 commits into from
Apr 26, 2021

Conversation

dertseha
Copy link
Contributor

@dertseha dertseha commented Apr 25, 2021

This PR extends go-gl/gl in the following ways:

Regenerate with KHR header
As identified in go-gl/gl comment , newest API specs all require the presence of KHR/khrplatform.h. glow was extended to download and provide this file as well, and this PR is the result of re-generating all APIs.

Fixes #125 .

checkptr problem fixes
As a side-effect of the re-generation, the previously introduced "overloads" feature is now also included.

To highlight the issue with checkptr detector, README.md was extended to detail what to do in such error cases.

Fixes #124 .
Should also handle #80 - though I don't think reported affected functions have a necessary overload.

Module
A module file was added to allow go-gl/gl to be used outside a GOPATH environment.
Futhermore, the code generation call to glow was extended to specify all paths, in order to allow glow also to be used outside GOPATH. (This change is in tandem with the corresponding PR go-gl/glow#115 .)

Detail: The minimum version was set to be Go 1.9. Although Travis build did specify 1.4 to be the earliest, this version could not be brought to work: The linker rejected the passed parameters (/usr/bin/ld: -r and -pie may not be used together). Version 1.9 was chosen because generated CGo code was not compatible with older versions when run with a 1.16 compiler (_cgo_gotypes.go:32:6: type aliases only supported as of -lang=go1.9)

Should help to get going with #102 .

Change of CI
Travis was dropped, and instead GitHub actions are in use now. This allows for a more complete test-matrix of multiple Go versions and environments.

It is likely that Travis would also support such test matrices, yet GitHub actions are more readily available - also for forks. This made testing for me easier.
I'm happy to provide corresponding changes to the other repositories as well.

@dertseha dertseha changed the title Regenerate with KHR header and overrides Regenerate with KHR header and overloads Apr 25, 2021
@errcw
Copy link
Member

errcw commented Apr 26, 2021

🎉 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants