New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cgo dependency on Windows #102

Open
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@hajimehoshi
Member

hajimehoshi commented Nov 12, 2018

Fixes go-gl/gl#109

Design Document

https://docs.google.com/document/d/1mqquznil9fR2amtb3eTC2ObCx3A8Af_5INqKjO-pKDg/edit?usp=sharing

tl;dr

I propose to eliminate Cgo usages on Windows from go-gl/gl by fixing go-gl/glow to generate code using syscall.Syscall.

@hajimehoshi

This comment has been minimized.

Member

hajimehoshi commented Nov 12, 2018

Please take a look: @slimsag @dmitshur

Show resolved Hide resolved functions.go Outdated
Show resolved Hide resolved functions.go Outdated
@hajimehoshi

This comment has been minimized.

Member

hajimehoshi commented Nov 14, 2018

friendly ping

@hajimehoshi

This comment has been minimized.

Member

hajimehoshi commented Dec 4, 2018

That's really sad that there has not been any feedback in the last 22 days. This change is really important (at least to me) e.g. in order to make compiling time shorten on Windows.

@pwaller

This comment has been minimized.

Member

pwaller commented Dec 4, 2018

Hi @hajimehoshi, thanks very much for your contribution. Sorry it is taking time, but please be aware that no one is paid to maintain these packages. It's a best effort in our spare time and we can only give so much. Please have patience and faith that we will get to it. Feel free to continue to send pings!

Show resolved Hide resolved tmpl/conversions.tmpl Outdated

hajimehoshi added a commit to hajimehoshi/ebiten that referenced this pull request Dec 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment