expose AddError via Dao interface #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems the error is not added to the current db but initialized a new one? |
Thanks @jinzhu for replying I opted to reuse the existing withError method that seems to be everywhere else. What do you think? |
jinzhu
reviewed
May 24, 2023
do.go
Outdated
| @@ -835,6 +835,10 @@ func (d *DO) newResultSlicePointer() interface{} { | |||
| return reflect.New(reflect.SliceOf(reflect.PtrTo(d.modelType))).Interface() | |||
| } | |||
|
|
|||
| func (d *DO) AddError(err error) error { | |||
| return d.withError(err).underlyingDB().Error | |||
There was a problem hiding this comment.
maybe change the code to
d.underlyingDB().AddError(err)?
There was a problem hiding this comment.
Thanks @jinzhu.
I have update the PR and noticed the old implementation won't propagate the error back correctly.
jeepc
pushed a commit
to jeepc/gen
that referenced
this pull request
Nov 20, 2023
* expose AddError via Dao interface * fix: mutate existing db to propagate the error back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
Expose
DB.AddError()to DAO interface.User Case Description
We build most of our queries using reusable
Scopes()functions. In most cases the query validates few constraints and needs a way to propagate the error back.