Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #755: calculate skip number in GetModelMethod #782

Merged
merged 5 commits into from
May 24, 2023

Conversation

miya-masa
Copy link
Contributor

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

Fix #755

@miya-masa miya-masa changed the title Fix #755 Fix #755: calculate skip number in GetModelMethod Mar 2, 2023
@jinzhu
Copy link
Member

jinzhu commented Apr 12, 2023

Hi @miya-masa

Can you add some tests?

@miya-masa
Copy link
Contributor Author

@jinzhu

I added some tests.

@jinzhu jinzhu requested a review from idersec May 10, 2023 09:40
@jinzhu jinzhu merged commit caf55f3 into go-gorm:master May 24, 2023
jeepc pushed a commit to jeepc/gen that referenced this pull request Jun 1, 2023
* fix(go-gorm#755): fix generate model

* test(gen-model): add test

* test(gen-model): fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not working gen.WithMethod
2 participants