-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: part 2 of distinguish between Unique and UniqueIndex #6822
Conversation
To unblock new PRs, can we just resolve the CI tests issue in a dedicated PR and then decide/proceed on merging this new feature? |
I have tested this mr with the above dependency, and it is OK. Then we need to merge the driver mrs , and update test/go.mod here. If all goes well, we can solve all the troubles today 😭 |
My God, I tested it as test/docker-composite.yml, and it missed mysql 5.6 |
This is the benefit of our CI, to catch oversights in our daily development ;) |
What a thrilling day, now we have fixed it 😭 |
What did this pull request do?
It's part 2 of #6386 which is the part of rollback, see #6386 (comment).
It will also fix the ci.
But note that it depends on
After the above requests is merged, this pr still needs to update tests/go.mod to the corresponding commit id.
User Case Description