Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : fail to alter existing boolean column from smallint with default value to boolean in postgres (#180) #181

Merged
merged 12 commits into from
May 28, 2023
Merged

fix : fail to alter existing boolean column from smallint with default value to boolean in postgres (#180) #181

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
63a6af7
fix : fail to alter column from smallint to boolean
jeffry-luqman Feb 28, 2023
6954705
fix : fail to alter column from smallint to boolean
jeffry-luqman Feb 28, 2023
7e0c798
fix : fail to alter column from string to boolean
jeffry-luqman Feb 28, 2023
38ba49b
fix : fail to alter column from string to boolean if the value is "fa…
jeffry-luqman Feb 28, 2023
e94db72
move using conversion expression to func
jeffry-luqman Mar 1, 2023
a291d48
move using expression to func
jeffry-luqman Mar 1, 2023
e9eea7c
Merge branch 'go-gorm:master' into master
jeffry-luqman Mar 10, 2023
92378fa
fix : fail to alter existing boolean column from smallint with defaul…
jeffry-luqman May 9, 2023
e9a5317
isUncastableDefaultValue
jeffry-luqman May 10, 2023
fbab906
ModifyColumn & DropDefaultValue
jeffry-luqman May 10, 2023
6634561
ModifyColumn + DropDefaultValue > modifyColumn
jeffry-luqman May 10, 2023
eef97b1
Merge branch 'master' into master
jeffry-luqman May 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions migrator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,8 +326,7 @@ func (m Migrator) AlterColumn(value interface{}, field string) error {
return err
}
} else {
if err := m.DB.Exec("ALTER TABLE ? ALTER COLUMN ? TYPE ?"+m.genUsingExpression(fileType.SQL, fieldColumnType.DatabaseTypeName()),
m.CurrentTable(stmt), clause.Column{Name: field.DBName}, fileType, clause.Column{Name: field.DBName}, fileType).Error; err != nil {
if err := m.modifyColumn(stmt, field, fileType, fieldColumnType); err != nil {
return err
}
}
Expand Down Expand Up @@ -387,14 +386,27 @@ func (m Migrator) AlterColumn(value interface{}, field string) error {
return nil
}

func (m Migrator) genUsingExpression(targetType, sourceType string) string {
if targetType == "boolean" {
switch sourceType {
func (m Migrator) modifyColumn(stmt *gorm.Statement, field *schema.Field, targetType clause.Expr, existingColumn *migrator.ColumnType) error {
alterSQL := "ALTER TABLE ? ALTER COLUMN ? TYPE ? USING ?::?"
isUncastableDefaultValue := false

if targetType.SQL == "boolean" {
switch existingColumn.DatabaseTypeName() {
case "int2", "int8", "numeric":
return " USING ?::INT::?"
alterSQL = "ALTER TABLE ? ALTER COLUMN ? TYPE ? USING ?::int::?"
}
isUncastableDefaultValue = true
}

if dv, _ := existingColumn.DefaultValue(); dv != "" && isUncastableDefaultValue {
if err := m.DB.Exec("ALTER TABLE ? ALTER COLUMN ? DROP DEFAULT", m.CurrentTable(stmt), clause.Column{Name: field.DBName}).Error; err != nil {
return err
}
}
return " USING ?::?"
if err := m.DB.Exec(alterSQL, m.CurrentTable(stmt), clause.Column{Name: field.DBName}, targetType, clause.Column{Name: field.DBName}, targetType).Error; err != nil {
return err
}
return nil
}

func (m Migrator) HasConstraint(value interface{}, name string) bool {
Expand Down