Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support pgx open db options #274

Closed
wants to merge 1 commit into from

Conversation

sasakiyori
Copy link

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

Enable the hooks which are supported by pgx, such as BeforeConnect, AfterConnect.

User Case Description

dialector := postgres.New(postgres.Config{
    DSN: "host=localhost user=postgres password=1 dbname=postgres port=5432 sslmode=disable",
    OpenOptions: []stdlib.OptionOpenDB{
        stdlib.OptionBeforeConnect(func(ctx context.Context, cfg *pgx.ConnConfig) error {
            fmt.Println("before connect")
            // do anything with the actual pgx connection config
	    return nil
        }),
    },
})

db, err := gorm.Open(dialector)

@jinzhu
Copy link
Member

jinzhu commented Jun 12, 2024

Thank you for your PR, but I suggest using it like https://gorm.io/docs/connecting_to_the_database.html#Existing-database-connection-1 to avoid relying too much on the driver.

@jinzhu jinzhu closed this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants