Update all vendored dependencies #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One small change was required - for irondb, Discover config option was removed at some point. Commented it out.
npazosmendez
approved these changes
Apr 25, 2024
|
May I ask why the modules are also included in the |
|
Historical reasons. That project predates modules and during early days having all dependencies in the repo was the mainstream way to go. It have some small benefits - e.x. it guarantees that build will be reproducible and original dev won't disable that with force-push or something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One small change was required - for irondb, Discover config option was removed at some point. Commented it out.