Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving H1D legend style - 2 #703

Merged
merged 5 commits into from
May 11, 2020
Merged

Improving H1D legend style - 2 #703

merged 5 commits into from
May 11, 2020

Conversation

rmadar
Copy link
Member

@rmadar rmadar commented May 10, 2020

PR following #689 (fixes #683)

@rmadar
Copy link
Member Author

rmadar commented May 10, 2020

OK I have simplified the legend and gave priority according to the following rules:

  • with fill: boxline and markers but disregard band
  • w/o fill: skyline, band and markers

image

If you think the last one is too crowded, we can also remove the marker when the histo is filled (I don't have a strong opinion here - and this setup shouldn't be used I think).

I'll update the *_golden.png files once we settle on the legend choice.

@sbinet
Copy link
Member

sbinet commented May 11, 2020

it looks fine.
and we can always adapt a bit after some experience has been gained.

thanks.

@codecov-io
Copy link

codecov-io commented May 11, 2020

Codecov Report

Merging #703 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #703      +/-   ##
==========================================
+ Coverage   70.35%   70.36%   +0.01%     
==========================================
  Files         359      359              
  Lines       46339    46365      +26     
==========================================
+ Hits        32600    32626      +26     
  Misses      11520    11520              
  Partials     2219     2219              
Impacted Files Coverage Δ
hplot/h1d.go 93.25% <100.00%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbdf79d...46429d4. Read the comment docs.

@sbinet sbinet merged commit 0f7b59f into go-hep:master May 11, 2020
@rmadar rmadar deleted the issue-689 branch May 11, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legend improvements
3 participants