Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codahale/hdrhistogram repo url has been transferred under the github HdrHstogram umbrella #39

Closed
filipecosta90 opened this issue Aug 16, 2021 · 3 comments

Comments

@filipecosta90
Copy link

Problem

The codahale/hdrhistogram repo has been transferred under the github HdrHstogram umbrella with the help from the original author in Sept 2020 (new repo url https://github.com/HdrHistogram/hdrhistogram-go). The main reasons are to group all implementations under the same roof and to provide more active contribution from the community as the original repository was archived several years ago.

The dependency URL should be modified to point to the new repository URL. The tag "v0.9.0" was applied at the point of transfer and will reflect the exact code that was frozen in the original repository.

If you are using Go modules, you can update to the exact point of transfer using the @v0.9.0 tag in your go get command.

go mod edit -replace github.com/codahale/hdrhistogram=github.com/HdrHistogram/hdrhistogram-go@v0.9.0

Performance Improvements

From the point of transfer, up until now (mon 16 aug 2021), we've released 3 versions that aim support the standard HdrHistogram serialization/exposition formats, and deeply improve READ performance.
We recommend to update to the latest version.

@taoso
Copy link
Member

taoso commented Aug 16, 2021

Hello @filipecosta90 , thanks for your kindly reminding.

However, the sniper does not dependent hdrhistogram directly. The github.com/uber/jaeger-client-go does. And we are planing to migrate to the opentelemetry code base once it ready. So we would not change this dependence by now.

@hunterhug
Copy link

can update some package in go.mod?

@taoso
Copy link
Member

taoso commented Mar 3, 2022

Actually, it is github.com/uber/jaeger-lib/metrics/metricstest requests the github.com/HdrHistogram/hdrhistogram-go. So I close the issue.

go mod why github.com/HdrHistogram/hdrhistogram-go
# github.com/HdrHistogram/hdrhistogram-go
sniper/cmd/cron
github.com/go-kiss/sniper/pkg/trace
github.com/uber/jaeger-client-go
github.com/uber/jaeger-client-go.test
github.com/uber/jaeger-lib/metrics/metricstest
github.com/HdrHistogram/hdrhistogram-go

@taoso taoso closed this as completed Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants