-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional transport/x.{Server,Client} types #184
Comments
Correct. I will have a pull request ready end of this week and will move on to looking into Thrift and net/rpc. We should also closely look at additional packages and see if they are not (accidentally) bound to a specific transport. Zipkin is a typical example which currently only supports the http transport. Together with the upcoming pull request I will be adding functions to the Zipkin package for usage with gRPC. Maybe we should add a feature matrix in the documentation identifying what is supported, being worked on or not supported. |
|
Is cap'n proto something worth supporting?
|
I would be happy to accept a PR for transport/capnproto! |
@peterbourgon was wondering if this was still something you were wanting? and if so, what do you suggest to do about the |
transport/netrpc would still be happily accepted, but I guess it would serve primarily as an example. transport/thrift would be quite nice to have, primarily as a way to get the same set of transport-level helpers in Thrift as we have in HTTP and gRPC — by this I mean the ServerBefore, ServerAfter, Finalizer, etc. funcs. |
Right now we have transport/http.Server, wrapping an endpoint.Endpoint and exposing it to HTTP. We need the same for other transports: gRPC, Thrift, net/rpc. I believe @basvanbeek is working on gRPC at the moment; this issue is to track the same work for Thrift and net/rpc.
The text was updated successfully, but these errors were encountered: