sd/eureka: remove data races in unit tests #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 7, 2017 10:05
Rather than first fetching a Eureka application's instances synchronously and then scheduling subsequent background updates, instead schedule the updates, wait on the first update to arrive, an then proceed. Revise the tests accordingly to no longer rely on a set of instances known to the (fake) server as distinct from any applications. Since applications are an intensional view of instances, like the real Eureka server we derive the presence of applications from the application names mentioned by instances. That is, without at least one instance declaring that it's a member of a given application, no such application exists.
The fargo library already provides the HTTPResponseStatusCode function to extract an HTTP status code from a returned error, but here we want to be able to inject similar errors for tests, so look for both a real fargo error indicating that a heartbeat attempt failed to find its target instance and a synthetic error returned by a fake connection during a test.
|
Closes #545. Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #545, revise the fake fargo components used in the Eureka-related tests to behave more like a real Eureka server, and reduce the tests' vulnerability to delays in asynchronously-arriving responses from the server by polling, with a limit in place to make the tests fail after polling for one second.
This proposal changes
eureka.Instancer's cache priming implementation, though the behavior observable by callers shouldn't change.