sd: add Stop method to Instancer interface #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every implementation (modulo mock/test impls) already provided this method, and so it makes sense to lift it to the interface definition. Closes #566.
|
as mentioned in the issue, it's a code smell, but not worth fighting over. LGTM. I would recommend a clear spec of the expected behavior of Stop() in the comments, e.g. "instancer guarantees no more updates will be sent to subscribers once the Stop() function returns". side note - I personally prefer using io.Closer signature for such methods. |
|
I'm ok with it. I have no preference for io.Closer over Stop. |
|
I think I prefer |
jamesgist
pushed a commit
to jamesgist/kit
that referenced
this pull request
Nov 1, 2024
sd: add Stop method to Instancer interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every implementation (modulo mock/test impls) already provided this method, and so it makes sense to lift it to the interface definition.
Closes #566.