Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track gauge values and support default tags for dogstatsd #588

Merged
merged 1 commit into from
Aug 14, 2017

Conversation

jfhamlin
Copy link
Contributor

@jfhamlin jfhamlin commented Jul 30, 2017

Dogstatsd doesn't support deltas for gauges, so we must maintain the raw gauge value ourselves. lv.Spaces don't support carrying over values from previous flush periods, so this implementation duplicates lv.Space's label value tree logic to map to Gauges rather than observations. The simpler implementation of https://github.com/go-kit/kit/blob/master/metrics/graphite/graphite.go#L69 won't fly here because Dogstatsd supports tags, and we need to return the same Gauge every time for a given (name, lvs...) tuple. The changes also add tracking for whether a gauge was written in a flush period to avoid sending every gauge value every time.

Also adds support for the tag analogue of the prefix parameter to dogstatsd.New.

#578

Dogstatsd doesn't support sending deltas for gauges, so we must
maintain the raw gauge value ourselves.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants