Set time unit on metrics.Timer #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbourgon
requested changes
Sep 15, 2017
metrics/timer.go
Outdated
| if d < 0 { | ||
| d = 0 | ||
| } | ||
| t.h.Observe(d) | ||
| } | ||
|
|
||
| // Unit sets the timer time unit |
There was a problem hiding this comment.
Please make this a proper sentence with punctuation, and provide more detail, e.g.
Unit sets the unit of the float64 emitted by the timer. By default, the timer emits seconds.
metrics/timer_test.go
Outdated
| @@ -31,3 +31,29 @@ func TestTimerSlow(t *testing.T) { | |||
| t.Errorf("want %.3f, have %.3f", want, have) | |||
| } | |||
| } | |||
|
|
|||
| func TestTimerUnit(t *testing.T) { | |||
|
|
|||
There was a problem hiding this comment.
Remove extraneous newline.
|
Thanks for your feedback @peterbourgon! I implemented the suggested changes, please have a further review. |
peterbourgon
approved these changes
Sep 15, 2017
|
Thanks! Test failures are unrelated. |
jamesgist
pushed a commit
to jamesgist/kit
that referenced
this pull request
Nov 1, 2024
Set time unit on metrics.Timer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #608.