Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicate rev= parameters for Delete() method #267

Merged
merged 3 commits into from
Dec 2, 2020
Merged

Conversation

flimzy
Copy link
Member

@flimzy flimzy commented Dec 2, 2020

Backport of #266

@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #267 (422cfbc) into v3 (487ff2f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               v3     #267   +/-   ##
=======================================
  Coverage   88.96%   88.96%           
=======================================
  Files          31       31           
  Lines        2002     2003    +1     
=======================================
+ Hits         1781     1782    +1     
  Misses        157      157           
  Partials       64       64           
Impacted Files Coverage Δ
chttp/chttp.go 94.75% <ø> (ø)
db.go 80.43% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 487ff2f...422cfbc. Read the comment docs.

@flimzy flimzy merged commit 2b1cc4b into v3 Dec 2, 2020
@flimzy flimzy deleted the duplicateParams-v3 branch December 2, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant