Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken redis example #156

Merged
merged 1 commit into from
Jun 9, 2024
Merged

fix: broken redis example #156

merged 1 commit into from
Jun 9, 2024

Conversation

ccoVeille
Copy link
Contributor

generated redis package conflicted with imported redis package

Fixes #153

generated redis package conflicted with imported redis package

Fixes go-kod#153
Copy link

codecov bot commented Jun 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.65%. Comparing base (2a56912) to head (20d22b1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #156   +/-   ##
=======================================
  Coverage   81.65%   81.65%           
=======================================
  Files          29       29           
  Lines        1804     1804           
=======================================
  Hits         1473     1473           
  Misses        226      226           
  Partials      105      105           
Flag Coverage Δ
unittests 81.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sysulq sysulq self-requested a review June 9, 2024 14:19
Copy link
Contributor

@sysulq sysulq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysulq sysulq merged commit 2b02b75 into go-kod:main Jun 9, 2024
4 checks passed
@ccoVeille ccoVeille deleted the redis-example branch June 9, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

task generate:struct2interface is broken because of examples/infra/redis/kod_gen_interface.go
2 participants