Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: remove go.lsp.dev/pkg dependency #23

Merged
merged 6 commits into from
Mar 22, 2022
Merged

all: remove go.lsp.dev/pkg dependency #23

merged 6 commits into from
Mar 22, 2022

Conversation

zchee
Copy link
Member

@zchee zchee commented Mar 22, 2022

all: remove go.lsp.dev/pkg dependency.

@zchee zchee self-assigned this Mar 22, 2022
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
@zchee zchee force-pushed the remove-pkg-deps branch 4 times, most recently from 93d8d78 to ae077bb Compare March 22, 2022 23:24
@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #23 (8c68d4f) into main (b55d5d7) will decrease coverage by 0.5%.
The diff coverage is 69.2%.

@@           Coverage Diff           @@
##            main     #23     +/-   ##
=======================================
- Coverage   54.4%   53.8%   -0.6%     
=======================================
  Files          8       8             
  Lines        707     642     -65     
=======================================
- Hits         385     346     -39     
+ Misses       283     261     -22     
+ Partials      39      35      -4     
Impacted Files Coverage Δ
handler.go 0.0% <0.0%> (ø)
conn.go 63.0% <66.6%> (-1.8%) ⬇️
serve.go 79.7% <100.0%> (+6.9%) ⬆️
message.go 38.6% <0.0%> (-0.6%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b55d5d7...8c68d4f. Read the comment docs.

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
@zchee zchee added the dependencies Pull requests that update a dependency file label Mar 22, 2022
@zchee zchee merged commit 8c68d4f into main Mar 22, 2022
@zchee zchee deleted the remove-pkg-deps branch March 22, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Development

Successfully merging this pull request may close these issues.

1 participant