Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: remove gojay and use github.com/segmentio/encoding/json #34

Merged
merged 12 commits into from
Mar 24, 2022

Conversation

zchee
Copy link
Member

@zchee zchee commented Mar 23, 2022

Remove gojay and use github.com/segmentio/encoding/json.

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
@zchee zchee force-pushed the segmentio-json branch 4 times, most recently from 2781645 to b2bdd44 Compare March 23, 2022 02:40
@go-language-server go-language-server deleted a comment from codecov bot Mar 23, 2022
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #34 (da30f9a) into main (d33fc40) will decrease coverage by 46.7%.
The diff coverage is 2.8%.

Impacted file tree graph

@@           Coverage Diff            @@
##            main     #34      +/-   ##
========================================
- Coverage   62.9%   16.1%   -46.8%     
========================================
  Files         40      17      -23     
  Lines       6332    1760    -4572     
========================================
- Hits        3986     285    -3701     
+ Misses      2307    1474     -833     
+ Partials      39       1      -38     
Flag Coverage Δ
gojay ?
json ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client.go 0.0% <0.0%> (ø)
handler.go 0.0% <0.0%> (ø)
selectionrange.go 0.0% <ø> (ø)
server.go 0.0% <0.0%> (ø)
base.go 82.1% <82.1%> (ø)
log.go 0.0% <0.0%> (ø)
basic.go 100.0% <0.0%> (ø)
window.go 100.0% <0.0%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d33fc40...da30f9a. Read the comment docs.

@zchee zchee force-pushed the segmentio-json branch 3 times, most recently from e4a63c8 to 5b91881 Compare March 23, 2022 08:18
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
@zchee zchee merged commit da30f9a into main Mar 24, 2022
@zchee zchee deleted the segmentio-json branch March 24, 2022 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant