Make encodeHeader return a new array #62
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Arrays in Go are mutable. This method currently replaces all values passed to
SetHeader
by their encoded version.This can be problematic in a scenario that the array passed to
SetHeader
is reused somewhere else in the code.Ex :
In the above example, the recipients passed to
SendMail
will be encoded and result in a501 5.1.3 Bad recipient address syntax
from any postfix server.In my opinion, the expected behaviour of
SetHeader
is not to mutate the values passed as arguments.Solution
The proposed change creates a new array of string of the same length as the header values passed in and fill it with the encoded values, therefore not touching the raw ones.