V2 #426
Open
V2 #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the deadlock reported by John Morales in MGO-57.
This is a refactoring of the first batch + cursor logic that is used in the Pipe and Repair methods, so it may be used both internally in other places and also externally when people depend on functionality not yet implemented in the driver.
Also fixes result.Cursor.NS handling, as mentioned by Jeff Yemin.
Issue reported by Daniel Gottlieb.
Fixed typo.
Fixed small documentation typo on GridFs.Create
Besides user error, that situation may happen when the synchronization goroutine finds the server unavailable. Reported by John Morales.
Updates #65.
Also improve the documentation for the index key handling. Updates #65.
MongoDB only supports a single index with a given index key, so the custom name is a distraction. It will create surprising behavior where a given index is not created because a different index with the same key already exists, and it breaks the use of the current API, such as with DropIndex which is based on the index key. Updates #65.
Reported by Louisa Berger.
At the moment it fails about 25% of the time - the reason needs to be worked out, but it's probably better to get the txn tests running first.
It fails sometimes in a way that seems like a timing issue - put a sleep in before retrying (up to 3 attempts).
If 10 1-second waits aren't enough then it's likely that the "no reachable servers" error isn't transient.
Make StartServer dial the server first to ensure it's up before it returns. Error logging showed that something else was already using port 50017. Picking a random port still gets collisions :(, so try picking an unused one instead.
This has better handling of used ports and error reporting. Remove mgo_test.go, it's not needed now. sim_test.go:simulate was relying on the mgoaddr global set in mgo_test.go, changed it to get the DBServer passed in.
This is needed so the txn tests can use dbtest.
Clarify the retry logic in Query.Apply.
Clarify what happens when test fails and what it might mean.
Increase bson.NewObjectId performance by caching the process id
Retry upserts that fail with "duplicate key error".
internal/sasl: don't crash on Windows if password not specified
dont mix input and output buffers in cgo calls
For now tested by hand due to new configdb option constraints introduced in current 3.3. Test harness will need to change yet again to adapt to latest supported options. :-(
Reported by Cezar Sá Espinola.
Fix the IsDup retry error handling on Apply.
Fix integer constant overflow on 32-bit systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.