Add ConnectWithDialer #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atercattus
reviewed
Nov 11, 2021
| @@ -55,10 +56,23 @@ func getNetProto(addr string) string { | |||
| func Connect(addr string, user string, password string, dbName string, options ...func(*Conn)) (*Conn, error) { | |||
| proto := getNetProto(addr) | |||
|
|
|||
| ctx, cancel := context.WithTimeout(context.Background(), time.Second*10) | |||
There was a problem hiding this comment.
Use 10*time.Second, please :)
But, LGTM.
lance6716
approved these changes
Nov 16, 2021
There was a problem hiding this comment.
also lgtm
@atercattus we can change it to your style after this PR merged :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need more control over how dialing is done - in particular, integrating directly with https://pkg.go.dev/github.com/GoogleCloudPlatform/cloudsql-proxy/proxy/proxy