Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle fake rotate event as real if binlog filename changed #753

Merged
merged 3 commits into from
Dec 14, 2022
Merged

handle fake rotate event as real if binlog filename changed #753

merged 3 commits into from
Dec 14, 2022

Conversation

gaojijun
Copy link
Contributor

Fix #752

mefcorvi
mefcorvi reviewed Dec 12, 2022
View reviewed changes
canal/sync.go Outdated Show resolved Hide resolved
@gaojijun gaojijun changed the title handle fake roate event as real if binlog filename changed handle fake rotate event as real if binlog filename changed Dec 12, 2022
@gaojijun gaojijun mentioned this pull request Dec 13, 2022
Closed
@lance6716
Copy link
Collaborator

lgtm

@mefcorvi do you have other comments?

@mefcorvi
Copy link
Contributor

LGTM

@lance6716 lance6716 merged commit 392e4ca into go-mysql-org:master Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mefcorvi mefcorvi mefcorvi left review comments

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

application need to handle some fake rotate events
3 participants
@gaojijun @lance6716 @mefcorvi