Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default prefix in ToGoName configurable so go-swagger can plug in the pascalize func. #35

Merged
merged 3 commits into from
Jul 4, 2019

Conversation

fredbi
Copy link
Member

@fredbi fredbi commented Jul 4, 2019

Make default prefix in ToGoName configurable so go-swagger can plug in the pascalize func.

In addition, fixed a few linting issues.

fixes go-swagger/go-swagger#1937

This will allow go-swagger to plus in here its pascalize func and
contribute fixing go-swagger/go-swagger#1937 (inconsistent naming rules)

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@codecov
Copy link

codecov bot commented Jul 4, 2019

Codecov Report

Merging #35 into master will increase coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   88.05%   88.27%   +0.21%     
==========================================
  Files          12       12              
  Lines        1080     1083       +3     
==========================================
+ Hits          951      956       +5     
+ Misses        106      105       -1     
+ Partials       23       22       -1
Impacted Files Coverage Δ
convert.go 100% <100%> (+2.17%) ⬆️
util.go 99.5% <100%> (ø) ⬆️
json.go 61.9% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beaa044...39c4025. Read the comment docs.

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@casualjim casualjim changed the title Fix go-swagger/go-swagger#1937 Make default prefix in ToGoName configurable so go-swagger can plug in the pascalize func. Jul 4, 2019
@casualjim casualjim merged commit de649ff into go-openapi:master Jul 4, 2019
@fredbi fredbi deleted the fix-1937 branch December 5, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swagger generates and uses different models in case of definition name starts with Digit
2 participants