Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed rendering bug for th, zh, ja #81

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

daksh-sehgal
Copy link

Fixes issue #80 by not excluding Chinese origin characters when calling SplitText(). Also fixes a rendering bug with zero width characters (found in languages like Thai).

@Kohirus
Copy link

Kohirus commented Aug 13, 2024

This fix is great, but there is a problem that if the text contains Spaces, it will force line breaks.

@Kohirus
Copy link

Kohirus commented Aug 13, 2024

I found the source of the problem, commented out the following in the MulitCell(), as well as the SplitText() and write(). Why do spaces need to be wrapped, maybe some languages ​​require this?

if c == ' '  {
     sep = i
     ls = l
    ns++
}

@sbinet
Copy link
Contributor

sbinet commented Sep 11, 2024

thanks for the PR. (and apologies for the belated answer)

could you add a testcase to this PR ?
(perhaps also adding a testcase exercizing what @Kohirus mentioned ?)

thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants