Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow to exclude more complex column definition #2008

Closed
wants to merge 1 commit into from

Conversation

bohdand-weka
Copy link

Right now ExcludeColumn works only for simple cases, for example

q.Column("alias.*").Exclude("*")

will not exclude this column.

By using regexp for parsing alias and column in exclude column method it will be possible to exclude more complex selectors, also added support for SafeQueryAppender

@elliotcourant
Copy link
Collaborator

This is far too complicated to merge to this project at this point. go-pg is basically maintenance mode only, and while Vladimir let me take over some of this stuff as I use go-pg heavily for work. At this point I might as well be the only maintainer, and this PR is too much for me to want to take on if something doesn't go well in the future. It's too large of a feature to add.

I'm sorry, I would really recommend forking go-pg and adding these features there and periodically pulling from upstream if there are any fixes.

@bohdand-weka
Copy link
Author

@elliotcourant we already made fork for us , this PR is just to share it with upstream (might be useful for others)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants