Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goreleaser can no longer be installed using goreleaser.sh #210

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

mem
Copy link
Contributor

@mem mem commented Apr 26, 2022

This installation method was deprecated because the associated tool has
been deprecated.

Download "by hand" and run checks before trying to use binary.

Signed-off-by: Marcelo E. Magallon marcelo.magallon@grafana.com

@mem mem force-pushed the fix_goreleaser branch 5 times, most recently from 66d70ad to 01ea20a Compare April 26, 2022 22:55
This installation method was deprecated because the associated tool has
been deprecated.

Download "by hand" and run checks before trying to use binary.

Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
@@ -2,7 +2,7 @@
executors:
golang:
docker:
- image: cimg/go:1.15
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

darwin/arm64 fails to build with this version

Comment on lines +17 to +22
- run: cd /tmp && curl -L --remote-name https://github.com/goreleaser/goreleaser/releases/download/v1.8.3/goreleaser_Linux_x86_64.tar.gz
- run: cd /tmp && curl -L --remote-name https://github.com/goreleaser/goreleaser/releases/download/v1.8.3/checksums.txt
- run: cd /tmp && sha256sum --ignore-missing -c checksums.txt
- run: mkdir -p /home/circleci/.local/bin
- run: tar -C /home/circleci/.local/bin -xf /tmp/goreleaser_Linux_x86_64.tar.gz goreleaser
- run: goreleaser release --skip-publish --snapshot --debug
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry about the hacky method...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's IMO better than curl | bash. 😹

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure! but I did not want to pack this into a script with less repetition, etc, just because I didn't want to deal with figuring out the CircleCI environment on top of trying to fix this.

I'll follow up with something that moves this to a script that's called from here

@@ -1,3 +1,4 @@
//go:build linux
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is because of the newer Go version

@@ -2,7 +2,7 @@
executors:
golang:
docker:
- image: cimg/go:1.15
- image: cimg/go:1.17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to bump all the way to 1.18?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw an issue in the goreleaser repo about not working with 1.18 yet, and I did not want to make the can of worms even bigger :-P

Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this.

@SuperQ SuperQ requested review from CHTJonas and sparrc April 27, 2022 08:04
Copy link
Member

@CHTJonas CHTJonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one - thanks! 🚀

@CHTJonas CHTJonas merged commit 64d100b into go-ping:master Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants