Remove uses of Fatalf which causes the application to quit if a custom logger is provided such as Uber zap #214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uber zap's logger does
os.Exit()
ifFatal()
orFatalf()
is called. Since go-ping supports custom loggers and in my case I pass in Uber zap's logger this causes my entire application to exit. RemovingFatal()
calls is safer. If we need to ensure this error is handled up the call chain we canpanic()
which is better since the code can recover from a panic. The code cannot recover from anos.Exit()
call.