Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom server return URL decoding #143

Merged
merged 1 commit into from
Jan 15, 2023
Merged

Fix custom server return URL decoding #143

merged 1 commit into from
Jan 15, 2023

Conversation

paskal
Copy link
Collaborator

@paskal paskal commented Jan 14, 2023

Previously the form escaped the return URL twice, preventing it from working.

Resolves #130.

@paskal paskal requested a review from umputun as a code owner January 14, 2023 21:45
@coveralls
Copy link

coveralls commented Jan 14, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 3920941997

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.736%
Totals Coverage Status
Change from base Build 3917137928: 0.0%
Covered Lines: 247
Relevant Lines: 258
💛 - Coveralls

@paskal
fix custom server return URL decoding
f471232 
Previously the form escaped the return URL twice,
preventing it from working.
@umputun umputun merged commit e13746b into master Jan 15, 2023
@umputun umputun deleted the paskal/fix_custom_server branch January 15, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umputun umputun Awaiting requested review from umputun umputun is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: (/_example) Using "Login with custom_123" results in "Invalid Request"
3 participants
@paskal @coveralls @umputun