Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add public method to append self-implemented handler to stack of handlers #59

Merged
merged 3 commits into from
Jun 28, 2020
Merged

add public method to append self-implemented handler to stack of handlers #59

merged 3 commits into from
Jun 28, 2020

Conversation

nbys
Copy link
Contributor

@nbys nbys commented Jun 24, 2020

Fixes #58

@coveralls
Copy link

coveralls commented Jun 24, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 148672546

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 94.5%
Totals Coverage Status
Change from base Build 144592376: 0.1%
Covered Lines: 189
Relevant Lines: 200
💛 - Coveralls

@nbys nbys marked this pull request as ready for review June 24, 2020 20:52
@nbys nbys requested a review from umputun as a code owner June 24, 2020 20:52
@umputun
Copy link
Member

umputun commented Jun 26, 2020 •
edited
Loading

looking good, thx. Will be nice to have it described in README

@umputun umputun merged commit e2b238f into go-pkgz:master Jun 28, 2020
@umputun umputun mentioned this pull request Jul 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umputun umputun umputun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Public method for self-implemented auth handler
3 participants
@nbys @coveralls @umputun