Add v3 compatible with simplelru #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7954144825Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 7977500528Details
💛 - Coveralls |
paskal
force-pushed
the
paskal/simplelru_compatibility
branch
2 times, most recently
from
99127fd
to
f51a0e7
Compare
|
I moved v2 copy to a separate commit to simplify the review. |
paskal
force-pushed
the
paskal/simplelru_compatibility
branch
from
f51a0e7
to
8e1ae6a
Compare
paskal
force-pushed
the
paskal/simplelru_compatibility
branch
2 times, most recently
from
a13f9f8
to
069c324
Compare
paskal
force-pushed
the
paskal/simplelru_compatibility
branch
2 times, most recently
from
6a4b028
to
37b55b5
Compare
v2 had most of the required functions, so this change adds missing ones to satisfy the simplelru interface. To do that, RemoveOldest started returning parameters, unlike being void as before. Another behaviour change is that Get and Peek now return the cached value in case it has already expired to be consistent with the `simplelru` implementation. Also, GetExpiration is added.
paskal
force-pushed
the
paskal/simplelru_compatibility
branch
from
37b55b5
to
f92250c
Compare
umputun
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2 had most of the required functions, so this change adds missing ones to satisfy the
simplelruinterface, addressing #6.To do that,
RemoveOldeststarted returning parameters, unlike being void as before.Another behaviour change is that Get and Peek now return the cached value in case it has already expired to be consistent with the
simplelruimplementation.Also, GetExpiration has been added, which resolves #7.