Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple improvements of code quality #11

Merged
merged 6 commits into from
Apr 26, 2020
Merged

Multiple improvements of code quality #11

merged 6 commits into from
Apr 26, 2020

Conversation

paskal
Copy link
Collaborator

@paskal paskal commented Apr 26, 2020

  • bump go modules
  • bump github.com/alicebob/miniredis to v2
  • match linter settings with remark42 project, fix found issues
  • replace assert.Nil(t, err) with NoError calls, as well as NotNil with Error
  • start running cache examples, make them work offline
  • introduce LoadingCache.Close function
  • add proper teardown to tests to prevent goroutine leak

Please merge with rebase.

Copy link
Member

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@umputun umputun merged commit de20610 into go-pkgz:master Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants