New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor caller reporting #4

Merged

umputun merged 2 commits into go-pkgz:master from zonescape:caller-report-refactoring

Mar 14, 2019

Contributor

zonescape commented Mar 13, 2019

I make some refactoring for caller reporting in other to simplify further improvements of the code.

separate the code for caller reporting
add checks for edge cases
don't use runtime.FuncForPC() because its usage is discouraged


          refactor caller reporting

9dec050

umputun reviewed

View reviewed changes

logger.go Outdated Show resolved Hide resolved


          simplify handling of the inability to request caller info

1922d93

Contributor Author

zonescape commented Mar 14, 2019

I simplify edge case checking a bit.

umputun merged commit a7f793b into go-pkgz:master

zonescape deleted the caller-report-refactoring branch

March 16, 2019 11:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment