Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ErrSizedGroup (context, multierror) #11

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

razor-87
Copy link
Contributor

@razor-87 razor-87 commented Oct 29, 2023

Hi,
yesterday I decided to take a closer look at the examples from the readme, in the process it turned out that the last example for ErrSizedGroup runs with an error cannot use func(ctx context.Context) error {…} (value of type func(ctx context.Context) error) as func() error value in argument to egrp.Go.

  • implement the correct logic for context cancellation
  • simplify the methods for the MultiError struct
  • tried to reduce the number of explicit locks

@razor-87 razor-87 force-pushed the errsizedgroup-context-multierror branch from 93f83d0 to c2baddc Compare October 29, 2023 14:23
@razor-87 razor-87 force-pushed the errsizedgroup-context-multierror branch from c2baddc to 9d2f513 Compare October 29, 2023 14:28
@coveralls
Copy link

coveralls commented Oct 29, 2023

Pull Request Test Coverage Report for Build 6737635799

  • 62 of 62 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.1%) to 100.0%

Totals Coverage Status
Change from base Build 6286685592: 1.1%
Covered Lines: 183
Relevant Lines: 183

💛 - Coveralls

@razor-87
Copy link
Contributor Author

Error: "1 error(s) occurred: [0] {err from function 101}" does not contain "err from function 100"

hmm, again the same error in the test

@razor-87 razor-87 force-pushed the errsizedgroup-context-multierror branch 2 times, most recently from f9d5798 to d0f7a20 Compare November 1, 2023 09:04
@razor-87 razor-87 force-pushed the errsizedgroup-context-multierror branch from d0f7a20 to 4d61fd3 Compare November 2, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants