Fix accessing fields in composed structs #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deankarn
reviewed
Feb 25, 2021
validator_instance.go
Outdated
| @@ -409,7 +409,10 @@ func (v *Validate) StructPartialCtx(ctx context.Context, s interface{}, fields . | |||
| if len(flds) > 0 { | |||
|
|
|||
| vd.misc = append(vd.misc[0:0], name...) | |||
| vd.misc = append(vd.misc, '.') | |||
| // Don't append empty name for composed structs | |||
| if string(vd.misc) != "" { | |||
There was a problem hiding this comment.
Can we check the length of vd.misc here instead of casting to a string? It would be one less allocation :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
This change fixes the issue with validating fields in composed structures when the validator uses
.before the composed struct in the parent one.Make sure that you've checked the boxes below before you submit PR:
@go-playground/admins