idletimer.cpp changed so as not to crash when compiled with mingw64, glib dependency replaced with gcc dependency #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround for malloc panics when compiling go-qml with mingw64. I haven't yet dug deep enough into the reasons why the valid looking static lazy singleton is causing the panic (not sure if the issue is Qt, mingw or cgo) but these changes work around the problem. Also dumped the glib dependency.
…generic gcc sync intrinsic memory barrier in place of glib's atomic_get Only tested on Windows with mingw64, but should be pretty portable across gcc-supported targets.
|
The logic in idletimer.cpp has been changed to not depend on glib anymore, and we have people successfully using the qml package on Windows. I'm closing this bug with the belief that it is fixed, but please do reopen if that's not the case. (/cc @gmcbay @htoothrot) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idletimer.cpp changed so as not to crash when compiled with mingw64, glib dependency replaced with gcc dependency
Only tested on Windows thus far.