allow cluster client to use limiter #1316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -145,6 +146,7 @@ func (opt *ClusterOptions) clientOptions() *Options { | |||
| IdleCheckFrequency: disableIdleCheck, | |||
|
|
|||
| TLSConfig: opt.TLSConfig, | |||
| Limiter: opt.Limiter, | |||
There was a problem hiding this comment.
I think we would want a limiter per node
|
@vmihailenco Hi, any idea on this PR? We have the same issue that may get help from this. Thanks. |
|
Looks good - thanks! |
|
@vmihailenco I believe we should pass a Limiter constructor to the option instead of a Limiter, as mentioned by @ThomasJannaud |
|
@walktall indeed. Please hold on - I think I have a solution. |
Sure, thanks! |
vmihailenco
added a commit
that referenced
this pull request
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code users can pass a limiter struct into cluster client then allow each node client in the cluster to use that limiter