feat: support eval_ro and evalsha_ro #2221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisonkun
commented
Sep 24, 2022
tisonkun
commented
Sep 24, 2022
tisonkun
commented
Sep 24, 2022
Comment on lines
+14
to
+15
| EvalRO(ctx context.Context, script string, keys []string, args ...interface{}) *Cmd | ||
| EvalShaRO(ctx context.Context, sha1 string, keys []string, args ...interface{}) *Cmd |
There was a problem hiding this comment.
I checked interface changes for Scripter and Cmdable don't affect implementation within go-redis, but changing interfaces can always affect its outside implementations...
There was a problem hiding this comment.
Thanks, this looks safe enough especially for v8.
Signed-off-by: tison <wander4096@gmail.com>
|
Looks good, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vmihailenco perhaps more tests are required. I don't find a good place to add more.
Style changes are due to auto formatter, pending to revert.
This closes #2218.