add ExpectSetArgs method #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there! What can we do to get this PR reviewed and merged? Thank you for opening this @agammell! |
|
Is this repo still active? |
|
Looks like this is now present in master. Closing the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GETSETis considered a deprecated command in Redis 6.2.0 with the recommended replacement command beingSETwith theGETargument provided.This preferred method is implemented in go-redis via the
SetArgsfunction, which takes aSetArgsinstance with theGetfield set totrue. But redismock does not currently support mocking theSetArgsfunction.This PR implements an
ExpectSetArgsfunctionality, allowing code written using it to be mocked.