Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new Column Primary option #14

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

lafriks
Copy link
Contributor

@lafriks lafriks commented Nov 4, 2021

Related to go-rel/rel#244

@lafriks lafriks added the enhancement New feature or request label Nov 4, 2021
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #14 (fbd0469) into main (df67437) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #14   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          541       543    +2     
=========================================
+ Hits           541       543    +2     
Impacted Files Coverage Δ
builder/table.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df67437...fbd0469. Read the comment docs.

Copy link
Member

@Fs02 Fs02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

builder/table.go Show resolved Hide resolved
@Fs02 Fs02 merged commit ea1b870 into go-rel:main Nov 4, 2021
@lafriks lafriks deleted the feat/support_col_primary branch November 4, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants