Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IsJSONType and IsXMLType more robust #174

Merged
merged 2 commits into from
Aug 10, 2018

Conversation

moorereason
Copy link
Contributor

The existing IsJSONType and IsXMLType regular expressions are here
generalized to work with any properly formatted media type.

The existing IsJSONType and IsXMLType regular expressions are here
generalized to work with any properly formatted media type.
@codecov
Copy link

codecov bot commented Aug 10, 2018

Codecov Report

Merging #174 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #174   +/-   ##
=======================================
  Coverage   96.24%   96.24%           
=======================================
  Files           9        9           
  Lines        1065     1065           
=======================================
  Hits         1025     1025           
  Misses         22       22           
  Partials       18       18
Impacted Files Coverage Δ
client.go 96.98% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2620251...b99e4f7. Read the comment docs.

@moorereason
Copy link
Contributor Author

Attempting to generalize the changes in #172.

Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moorereason Thank you for the PR and improving resty.

@jeevatkm jeevatkm added this to the v1.9.0 Milestone milestone Aug 10, 2018
@jeevatkm jeevatkm merged commit 8f9bf7b into go-resty:master Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants