Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go.mod #190

Closed
wants to merge 1 commit into from
Closed

Update go.mod #190

wants to merge 1 commit into from

Conversation

1e0ng
Copy link

@1e0ng 1e0ng commented Sep 28, 2018

It is mandatory to omit v0 or v1 according to Why are v0, v1 omitted in the import paths? Why must the others appear? Why must v0, v1 never appear? in golang/go#24301

It is mandatory to omit `v0` or `v1` according to `Why are v0, v1 omitted in the import paths? Why must the others appear? Why must v0, v1 never appear?` in golang/go#24301
@codecov
Copy link

codecov bot commented Sep 28, 2018

Codecov Report

Merging #190 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #190   +/-   ##
=======================================
  Coverage   96.48%   96.48%           
=======================================
  Files           9        9           
  Lines        1109     1109           
=======================================
  Hits         1070     1070           
  Misses         21       21           
  Partials       18       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 466835f...1df509f. Read the comment docs.

@jeevatkm
Copy link
Member

@leonsim Thank you for the PR.

Yes, I know the spec. The current go.mod definition is kept for existing resty users support and compatibility. Probably you know about go lib usage via gopkg.in.

Resty would adapt go modules definition 100% from v2 release onwards, not now.

I'm curious does it work without v1 definition in the go.mod with gopkg.in. If yes, could you please share the steps you have taken to accomplish.

@1e0ng
Copy link
Author

1e0ng commented Sep 29, 2018

Yes, it does work with without v1 definition in the go.mod with gopkg.in.
To prove this, I push my changes to the master branch of my folked repo, and create a new tag v1.9.2. Now you can see this new tag in https://gopkg.in/leonsim/resty.v1

Actually, I created this PR because I got an error when I run go mod tidy command in one of my projects. It complains not able to parse the go.mod file in resty repo.

@jeevatkm
Copy link
Member

@leonsim Thanks for the details. I would like to keep go mod definition as is till v2 release without impacting existing users (without changing import path). More info #178 & #181 around go mod.


Actually, I created this PR because I got an error when I run go mod tidy command in one of my projects. It complains not able to parse the go.mod file in resty repo.

This is strange, I have actually verified with v1.9.1 no issues with any commands from go mod (#178 & #181). Could you please clear your local copies and try v1.9.1 and let me know.

@1e0ng
Copy link
Author

1e0ng commented Sep 30, 2018

After I update go.mod to require gopkg.in/resty.v1 v1.9.1 and then go mod tidy works without any error.

@1e0ng 1e0ng closed this Sep 30, 2018
@1e0ng 1e0ng deleted the patch-1 branch September 30, 2018 07:36
@jeevatkm
Copy link
Member

@leonsim Nice, it works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants