Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev iteration #340

Merged
merged 3 commits into from
May 12, 2020
Merged

Dev iteration #340

merged 3 commits into from
May 12, 2020

Conversation

jeevatkm
Copy link
Member

@jeevatkm jeevatkm commented May 11, 2020 •
edited
Loading

Close #339
Close #330

@jeevatkm jeevatkm added this to the v2.3.0 Milestone milestone May 11, 2020
@jeevatkm jeevatkm self-assigned this May 11, 2020
@codecov
Copy link

codecov bot commented May 11, 2020 •
edited
Loading

Codecov Report

Merging #340 into master will increase coverage by 0.43%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #340      +/-   ##
==========================================
+ Coverage   95.72%   96.16%   +0.43%     
==========================================
  Files           9       10       +1     
  Lines        1217     1224       +7     
==========================================
+ Hits         1165     1177      +12     
+ Misses         30       26       -4     
+ Partials       22       21       -1
Impacted Files Coverage Δ
client.go 96.72% <ø> (-0.16%) ⬇️
middleware.go 91.41% <100.00%> (+0.03%) ⬆️
response.go 100.00% <100.00%> (ø)
transport.go 100.00% <100.00%> (ø)
util.go 93.93% <100.00%> (+3.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98f59aa...6ad880c. Read the comment docs.

@jeevatkm jeevatkm requested a review from moorereason May 11, 2020 20:13
moorereason
moorereason approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@moorereason moorereason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jeevatkm jeevatkm merged commit e7fae0d into master May 12, 2020
@jeevatkm jeevatkm deleted the dev-iteration branch May 14, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moorereason moorereason moorereason approved these changes

Assignees

@jeevatkm jeevatkm

Labels
None yet
Milestone
v2.3.0 Milestone
Development

Successfully merging this pull request may close these issues.

Address HTTP/2.0 issue for go1.13 onwards Bug: invalid memory address or nil pointer dereference
2 participants
@jeevatkm @moorereason